-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to skip unchanged images during refresh #76
Open
nerikosans
wants to merge
4
commits into
iampava:master
Choose a base branch
from
nerikosans:feature/caching-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Hi @iampava, would you kindly take a look at this? I would appreciate it so much! |
+1 |
8 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
@iampava Please review this. Seems like a really amazing feature to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for publishing this great plugin.
This pull request fixes #14 , adding
skipUnchanged
option.Implementation Summary
When
skipUnchanged
istrue
, it stores the SHA-256 hash value of each images to be converted. Like below:Then during refreshes, conversions are skipped if the target image's hash is already stored.
Note: This implementation is inspired by an official example from webpack for monitoring changed chunks.
https://webpack.js.org/contribute/plugin-patterns/#changed-chunks
Experimental results
Experiments on test projects showed this change saves a considerable ratio of runtime. 🎉
Webpack 5: ~800ms → ~150ms
skipUnchanged
It detects and converts newly added/modified images:
Webpack 4: ~1300ms → ~350ms
skipUnchanged